msn-tldr commented on code in PR #14384: URL: https://github.com/apache/kafka/pull/14384#discussion_r1346188807
########## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ########## @@ -3146,6 +3149,97 @@ public void testInvalidTxnStateIsAnAbortableError() throws Exception { txnManager.beginTransaction(); } + @Test + public void testProducerBatchRetriesWhenPartitionLeaderChanges() throws Exception { + Metrics m = new Metrics(); + SenderMetricsRegistry senderMetrics = new SenderMetricsRegistry(m); + try { + // SETUP + String metricGrpName = "producer-metrics-test-stats-1"; + long totalSize = 1024 * 1024; + BufferPool pool = new BufferPool(totalSize, batchSize, metrics, time, + metricGrpName); + long retryBackoffMaxMs = 100L; Review Comment: `time.sleep(2 * retryBackoffMaxMs);` that is how i ensure that tests waits more than backoff period before retrying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org