kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1346545044
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchBuffer.java:
##########
@@ -37,7 +36,7 @@
*
* <em>Note</em>: this class is not thread-safe and is intended to only be
used from a single thread.
*/
-public class FetchBuffer implements Closeable {
+public class FetchBuffer implements AutoCloseable {
Review Comment:
For point #1, the background thread has a _separate_ fetch buffer. It
doesn't write to the same object. The application thread `FetchBuffer` is
created in `PrototypeAsyncConsumer` and the background thread `FetchBuffer` is
created in `AbstractFetch`.
For point #2, I think your [other
comment](https://github.com/apache/kafka/pull/14406#discussion_r1342984775) is
correct. I'm not yet sure how to maintain those two fetch buffers separately
without running into that race condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
