showuon commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1347125857
########## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ########## @@ -541,6 +542,131 @@ class RemoteIndexCacheTest { verifyFetchIndexInvocation(count = 1) } + @Test + def testIndexFileAlreadyExistOnDiskButNotInCache(): Unit = { Review Comment: Yes, I think test the real flow makes more sense. We can change the `testIndexFileAlreadyExistOnDiskButNotInCache` into the flow above. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org