mimaison commented on code in PR #14473: URL: https://github.com/apache/kafka/pull/14473#discussion_r1347410102
########## gradle/dependencies.gradle: ########## @@ -158,9 +158,6 @@ versions += [ slf4j: "1.7.36", snappy: "1.1.10.5", spotbugs: "4.7.3", - // New version of Swagger 2.2.14 requires minimum JDK 11. Review Comment: Can we keep this comment in gradle.properties? I created https://issues.apache.org/jira/browse/KAFKA-15549 to remember us we will be able to bump it once support for Java 8 is removed. ########## build.gradle: ########## @@ -37,7 +37,7 @@ plugins { id 'java-library' id 'org.owasp.dependencycheck' version '8.2.1' id 'org.nosphere.apache.rat' version "0.8.1" - id "io.swagger.core.v3.swagger-gradle-plugin" version "2.2.8" // keep aligned with the swagger version used in gradle/dependencies.gradle + id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVersion}" // keep aligned with the swagger version used in gradle/dependencies.gradle Review Comment: I guess we can remove the comment if we have the version in a single place ########## build.gradle: ########## @@ -938,7 +938,7 @@ project(':core') { exclude group: 'junit', module: 'junit' } testImplementation libs.caffeine - Review Comment: Can we undo this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
