jolshan commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1347989806
##########
core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala:
##########
@@ -143,10 +150,12 @@ class CoordinatorLoaderImpl[T](
currentOffset = batch.nextOffset
}
+ numBytes = numBytes + memoryRecords.sizeInBytes()
}
+ val endTimeMs = time.milliseconds()
if (isRunning.get) {
- future.complete(null)
+ future.complete(new LoadSummary(startTimeMs, endTimeMs,
numRecords, numBytes))
Review Comment:
should we include information about the LoadSummary in the PR description as
well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
