[ 
https://issues.apache.org/jira/browse/KAFKA-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773185#comment-17773185
 ] 

Divij Vaidya commented on KAFKA-15565:
--------------------------------------

I agree with [~pnee] . This does not seem like a bug because the timeout at the 
place in the code you mentioned is overriden just before sending at  
[https://github.com/apache/kafka/blob/bf51a50a564ee43d3515c82fc706f17325c4602f/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java#L571]
 where the overriden value of "timeout" is derived from the config you 
mentioned at 
[https://github.com/apache/kafka/blob/bf51a50a564ee43d3515c82fc706f17325c4602f/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java#L1461]
 

> KafkaAdminClient does not honor request timeout ms 
> ---------------------------------------------------
>
>                 Key: KAFKA-15565
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15565
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Sankalp Bhatia
>            Assignee: Sankalp Bhatia
>            Priority: Minor
>
> It seems to me there is a bug in this line in the KafkaAdminClient. For the 
> constructor arg defaultRequestTimeoutMs of NetworkClient [1], it uses a 
> hardcoded value of 1 hour.  Ideally, this should be derived from the client 
> config     "request.timeout.ms"  from the AdminClientConfig[2]. 
> References
> [1][https://github.com/apache/kafka/blob/1c3eb4395a15cf4f45b6dc0d39effb3dc087f5a4/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java#L521]
> [2][https://github.com/apache/kafka/blob/1c3eb4395a15cf4f45b6dc0d39effb3dc087f5a4/clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java#L98]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to