hudeqi commented on PR #14482: URL: https://github.com/apache/kafka/pull/14482#issuecomment-1752610656
> > > @hudeqi @showuon There is one test case failing related to the above change #14381, can you help me resolving it , in the local it is not failing ? `Build / JDK 8 and Scala 2.12 / testClearCacheAndIndexFilesWhenResizeCache() – kafka.log.remote.RemoteIndexCacheTest` `java.io.UncheckedIOException: java.nio.file.NoSuchFileException: /tmp/kafka-RemoteIndexCacheTest5502978390891743756/mwbAzcjOTtKRIDxlQrgTTw:foo-0/remote-log-index-cache/0_xg9JTaPnS4C47HfCgv2_gA.txnindex.deleted` https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14482/12/tests/ > > > > > > hi, I think this may be the reason: when executing `getIndexFileFromRemoteCacheDir`, the .deleted file will be listed in the `filter(Files.isRegularFile(_))` stage, but when executing `path.getFileName.toString`, the .deleted file has already been deleted because `cleanStarted` is already true to start cleaning. If possible, can I fix this issue in your branch? @iit2009060 > > Yes sure @hudeqi . This seems to be a case of flaky behaviour i.e. race condition ? I think so, please cherry-pick this commit, thanks. @iit2009060 > > > @hudeqi @showuon There is one test case failing related to the above change #14381, can you help me resolving it , in the local it is not failing ? `Build / JDK 8 and Scala 2.12 / testClearCacheAndIndexFilesWhenResizeCache() – kafka.log.remote.RemoteIndexCacheTest` `java.io.UncheckedIOException: java.nio.file.NoSuchFileException: /tmp/kafka-RemoteIndexCacheTest5502978390891743756/mwbAzcjOTtKRIDxlQrgTTw:foo-0/remote-log-index-cache/0_xg9JTaPnS4C47HfCgv2_gA.txnindex.deleted` https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14482/12/tests/ > > > > > > hi, I think this may be the reason: when executing `getIndexFileFromRemoteCacheDir`, the .deleted file will be listed in the `filter(Files.isRegularFile(_))` stage, but when executing `path.getFileName.toString`, the .deleted file has already been deleted because `cleanStarted` is already true to start cleaning. If possible, can I fix this issue in your branch? @iit2009060 > > Yes sure @hudeqi . This seems to be a case of flaky behaviour i.e. race condition ? I think so, please cherry-pick this commit: https://github.com/hudeqi/kafka/commit/854c773e708a8352d018986873743b325e97c3f5, thanks. @iit2009060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
