ocadaruma opened a new pull request, #14513:
URL: https://github.com/apache/kafka/pull/14513

   ## Summary
   
   - Currently, ReplicaFetcherThreadBenchmark doesn't run due to 2 reasons:
     * NPE that is introduced by 
https://github.com/apache/kafka/commit/755e04a41dfd00dd4587b0fe0980befd0ae5c433
         - ZkMetadataCache instantiation causes NPE because we pass `null` for 
`kraftControllerNodes` but it should be `Seq.empty`
     * NotLeaderOrFollowerException that is introduced by 
https://github.com/apache/kafka/commit/3467036e017adc3ac0919bbc0c067b1bb1b621f3
         - Even we address above NPE issue, we still get 
NotLeaderOrFollowerException
         - ```
           org.apache.kafka.common.errors.NotLeaderOrFollowerException: Error 
while fetching partition state for topic-30
           ```
         - This is because replicaManager doesn't host partitions when 
RemoteLeaderEndPoint tries to build fetches
   - This PR addresses these problems
   - NPE issue on ZkMetadataCache instantiation also occurs in other several 
benchmarks. This PR also fix these benchmarks.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to