jolshan commented on code in PR #14489:
URL: https://github.com/apache/kafka/pull/14489#discussion_r1350503797
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##########
@@ -515,7 +521,10 @@ class TransactionStateManager(brokerId: Int,
* metadata cache with the transactional ids. This operation must be
resilient to any partial state left off from
* the previous loading / unloading operation.
*/
- def loadTransactionsForTxnTopicPartition(partitionId: Int, coordinatorEpoch:
Int, sendTxnMarkers: SendTxnMarkersCallback): Unit = {
+ def loadTransactionsForTxnTopicPartition(partitionId: Int,
+ coordinatorEpoch: Int,
+ sendTxnMarkers:
SendTxnMarkersCallback,
+ hadTransactionStateAlreadyLoaded:
Boolean): Unit = {
Review Comment:
I actually had it this way before, but we load in this method (and check
afterwards) so I thought "had" conveyed that this happened before the method. I
will think a bit more about this because there may be a better way to phrase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
