kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1352879009
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestManager.java:
##########
@@ -16,13 +16,48 @@
*/
package org.apache.kafka.clients.consumer.internals;
+import org.apache.kafka.clients.consumer.Consumer;
import
org.apache.kafka.clients.consumer.internals.NetworkClientDelegate.PollResult;
+import static
org.apache.kafka.clients.consumer.internals.NetworkClientDelegate.PollResult.EMPTY;
+
/**
* {@code PollResult} consist of {@code UnsentRequest} if there are requests
to send; otherwise, return the time till
* the next poll event.
*/
public interface RequestManager {
+
+ /**
+ * During normal operation of the {@link Consumer}, a request manager may
need to send out network requests.
+ * Implementations can return {@link PollResult their need for network
I/O} by returning the requests here.
+ * Because the {@code poll} method is called within the single-threaded
context of the consumer's main network
+ * I/O thread, there should be no need for synchronization protection
within itself or other state.
+ *
+ * <p/>
+ *
+ * <em>Note</em>: no network I/O occurs in this method. The method itself
should not block on I/O or for any
+ * other reason. This method is called from by the consumer's main network
I/O thread. So quick execution of
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
