rreddy-22 commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1353045452
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -91,6 +91,27 @@ public class GroupCoordinatorConfig {
*/
public final int genericGroupMaxSessionTimeoutMs;
+ /**
+ * Frequency at which to check for expired offsets.
+ */
+ public final long offsetsRetentionCheckIntervalMs;
+
+ /**
+ * For subscribed consumers, committed offset of a specific partition will
be expired and discarded when
+ * 1) this retention period has elapsed after the consumer group loses
all its consumers (i.e. becomes empty);
+ * 2) this retention period has elapsed since the last time an offset
is committed for the partition AND
+ * the group is no longer subscribed to the corresponding topic.
+ *
+ * For standalone consumers (using manual assignment), offsets will be
expired after this retention period has
+ * elapsed since the time of last commit.
+ *
+ * Note that when a group is deleted via the DeleteGroups request, its
committed offsets will also be deleted immediately;
+ *
+ * Also, when a topic is deleted via the delete-topic request, upon
propagated metadata update any group's
+ * committed offsets for that topic will also be deleted without extra
retention period
Review Comment:
nit: missing period
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -91,6 +91,27 @@ public class GroupCoordinatorConfig {
*/
public final int genericGroupMaxSessionTimeoutMs;
+ /**
+ * Frequency at which to check for expired offsets.
+ */
+ public final long offsetsRetentionCheckIntervalMs;
+
+ /**
+ * For subscribed consumers, committed offset of a specific partition will
be expired and discarded when
+ * 1) this retention period has elapsed after the consumer group loses
all its consumers (i.e. becomes empty);
+ * 2) this retention period has elapsed since the last time an offset
is committed for the partition AND
+ * the group is no longer subscribed to the corresponding topic.
+ *
+ * For standalone consumers (using manual assignment), offsets will be
expired after this retention period has
+ * elapsed since the time of last commit.
+ *
+ * Note that when a group is deleted via the DeleteGroups request, its
committed offsets will also be deleted immediately;
+ *
+ * Also, when a topic is deleted via the delete-topic request, upon
propagated metadata update any group's
Review Comment:
nit: missing period
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
