Re: [PR] KAFKA-14517:Implement regex subscriptions [kafka]

[via GitHub]

JimmyWang6 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1757298813

   @dajac 
   Much Thanks for your review！
   As for target assignment updates, the function 
`maybeUpdateSubscribedTopicNames(oldMember, newMember)`
   
![image](https://github.com/apache/kafka/assets/48462172/a6b17c61-6686-4069-b729-a332d5439150)
   The old member's **RegexSubscribedTopics** has been converted to 
**subscribedTopicNames()**, 
   and subscriptions can be reduced by using 
subscribedTopicCount.compute(topicName, ConsumerGroup::decValue). 
   The new member's RegexSubscribedTopics will be transformed into 
subscribedTopicNames through **getRegexSubscribedTopics()**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org