CalvinConfluent commented on code in PR #14312:
URL: https://github.com/apache/kafka/pull/14312#discussion_r1357251569
##########
metadata/src/main/resources/common/metadata/PartitionChangeRecord.json:
##########
@@ -40,6 +42,15 @@
"versions": "0+", "nullableVersions": "0+", "taggedVersions": "0+",
"tag": 4,
"about": "null if the adding replicas didn't change; the new adding
replicas otherwise." },
{ "name": "LeaderRecoveryState", "type": "int8", "default": "-1",
"versions": "0+", "taggedVersions": "0+", "tag": 5,
- "about": "-1 if it didn't change; 0 if the leader was elected from the
ISR or recovered from an unclean election; 1 if the leader that was elected
using unclean leader election and it is still recovering." }
+ "about": "-1 if it didn't change; 0 if the leader was elected from the
ISR or recovered from an unclean election; 1 if the leader that was elected
using unclean leader election and it is still recovering." },
+ { "name": "EligibleLeaderReplicas", "type": "[]int32", "default": "null",
"entityType": "brokerId",
+ "versions": "1+", "nullableVersions": "1+", "taggedVersions": "1+",
"tag": 6,
+ "about": "null if the ELR didn't change; the new eligible leader
replicas otherwise." },
+ { "name": "LastKnownELR", "type": "[]int32", "default": "null",
"entityType": "brokerId",
+ "versions": "1+", "nullableVersions": "1+", "taggedVersions": "1+",
"tag": 7,
+ "about": "null if the LastKnownELR didn't change; the last known
eligible leader replicas otherwise." },
+ { "name": "LastKnownLeader", "type": "int32", "default": "-2",
"entityType": "brokerId",
Review Comment:
Synced offline, make the lastKnownLeader a tagged field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
