mjsax commented on PR #12988: URL: https://github.com/apache/kafka/pull/12988#issuecomment-1760676675
Thanks for digging into this -- I think you are spot on -- seem we should extract a method that will set KS controlled config, and refactor `getMainConsumerConfigs` to first call `getCommonConsumerConfigs()`, than apply `main.consumer` configs, and in a last step call the new method to set KS controlled configs. I assume we need to do something similar for restore and global consumer? -- To be fair, I was actually aware that something is off and still have a (old and stale) local branch adding corresponding testing to `StreamsConfigTest` to verify that overwrite hierarchy works as expected... Would be great if you could also look into this test... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
