riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1358490015
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ########## @@ -545,6 +547,26 @@ public String currentAssignmentSummary() { ')'; } + public ConsumerGroupDescribeResponseData.Member asConsumerGroupDescribeMember() { + return new ConsumerGroupDescribeResponseData.Member() + .setMemberEpoch(memberEpoch) + .setMemberId(Uuid.fromString(memberId)) + .setAssignment(new ConsumerGroupDescribeResponseData.Assignment() + .setTopicPartitions( + assignedPartitions.entrySet().stream().map( + item -> new ConsumerGroupDescribeResponseData.TopicPartitions() + .setTopicId(item.getKey()) + .setPartitions(new ArrayList<>(item.getValue())) + ).collect(Collectors.toList()) + )) + .setClientHost(clientHost) + .setClientId(clientId) + .setInstanceId(instanceId) + .setRackId(rackId) + .setSubscribedTopicNames(subscribedTopicNames) + .setSubscribedTopicRegex(subscribedTopicRegex); Review Comment: The targetAssignment is still unset here. Do we need to calculate it from pendingRevocations and pendingAssignments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org