guozhangwang commented on code in PR #14550:
URL: https://github.com/apache/kafka/pull/14550#discussion_r1359652648
##########
streams/src/main/java/org/apache/kafka/streams/kstream/ForeachAction.java:
##########
@@ -27,15 +27,18 @@
*
* @param <K> key type
* @param <V> value type
+ *
* @see KStream#foreach(ForeachAction)
*/
public interface ForeachAction<K, V> {
/**
* Perform an action for each record of a stream.
*
- * @param key the key of the record
- * @param value the value of the record
+ * @param key
Review Comment:
Is this newline necessary?
##########
streams/src/main/java/org/apache/kafka/streams/kstream/Branched.java:
##########
@@ -125,21 +149,14 @@ public static <K, V> Branched<K, V> withConsumer(final
Consumer<? super KStream<
return new Branched<>(name, null, chain);
}
- /**
- * Create an instance of {@code Branched} from an existing instance.
- *
- * @param branched the instance of {@code Branched} to copy
- */
- protected Branched(final Branched<K, V> branched) {
Review Comment:
I'm assuming this is just for moving the func around, and removing the
javadoc for those protected functions?
##########
streams/src/main/java/org/apache/kafka/streams/kstream/Branched.java:
##########
@@ -57,29 +64,36 @@ public static <K, V> Branched<K, V> as(final String name) {
/**
* Create an instance of {@code Branched} with provided chain function.
*
- * @param chain A function that will be applied to the branch. If the
provided function returns
- * {@code null}, its result is ignored, otherwise it is added
to the {@code Map} returned
- * by {@link BranchedKStream#defaultBranch()} or {@link
BranchedKStream#noDefaultBranch()} (see
- * {@link BranchedKStream} description for details).
- * @param <K> key type
- * @param <V> value type
+ * @param chain
+ * A function that will be applied to the branch. If the provided
function returns
+ * {@code null}, its result is ignored, otherwise it is added to
the {@code Map} returned
+ * by {@link BranchedKStream#defaultBranch()} or {@link
BranchedKStream#noDefaultBranch()} (see
+ * {@link BranchedKStream} description for details).
+ *
+ * @param <K> key type
+ * @param <V> value type
+ *
* @return a new instance of {@code Branched}
*/
public static <K, V> Branched<K, V> withFunction(
- final Function<? super KStream<K, V>, ? extends KStream<K, V>>
chain) {
+ final Function<? super KStream<K, V>, ? extends KStream<K, V>>
chain
Review Comment:
Ditto here?
##########
streams/src/main/java/org/apache/kafka/streams/kstream/Initializer.java:
##########
@@ -16,12 +16,12 @@
*/
package org.apache.kafka.streams.kstream;
-
/**
* The {@code Initializer} interface for creating an initial value in
aggregations.
* {@code Initializer} is used in combination with {@link Aggregator}.
*
- * @param <VA> aggregate value type
+ * @param <VAag> aggregate value type
Review Comment:
Agg? :)
##########
streams/src/main/java/org/apache/kafka/streams/kstream/Branched.java:
##########
@@ -90,33 +104,43 @@ public static <K, V> Branched<K, V> withConsumer(final
Consumer<KStream<K, V>> c
/**
* Create an instance of {@code Branched} with provided chain function and
branch name suffix.
*
- * @param chain A function that will be applied to the branch. If the
provided function returns
- * {@code null}, its result is ignored, otherwise it is added
to the {@code Map} returned
- * by {@link BranchedKStream#defaultBranch()} or {@link
BranchedKStream#noDefaultBranch()} (see
- * {@link BranchedKStream} description for details).
- * @param name the branch name suffix to be used. If {@code null}, a
default branch name suffix will be generated
- * (see {@link BranchedKStream} description for details)
- * @param <K> key type
- * @param <V> value type
+ * @param chain
+ * A function that will be applied to the branch. If the provided
function returns
+ * {@code null}, its result is ignored, otherwise it is added to
the {@code Map} returned
+ * by {@link BranchedKStream#defaultBranch()} or {@link
BranchedKStream#noDefaultBranch()} (see
+ * {@link BranchedKStream} description for details).
+ * @param name
+ * the branch name suffix to be used. If {@code null}, a default
branch name suffix will be generated
+ * (see {@link BranchedKStream} description for details)
+ *
+ * @param <K> key type
+ * @param <V> value type
+ *
* @return a new instance of {@code Branched}
*/
public static <K, V> Branched<K, V> withFunction(
- final Function<? super KStream<K, V>, ? extends KStream<K, V>>
chain, final String name) {
+ final Function<? super KStream<K, V>, ? extends KStream<K, V>> chain,
Review Comment:
Ditto here, I feel these newlines are not very necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
