lianetm commented on code in PR #14390:
URL: https://github.com/apache/kafka/pull/14390#discussion_r1361391346
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -231,25 +246,23 @@ public NetworkClientDelegate.UnsentRequest
toUnsentRequest() {
private class OffsetFetchRequestState extends RequestState {
public final Set<TopicPartition> requestedPartitions;
- public final GroupState.Generation requestedGeneration;
- private final CompletableFuture<Map<TopicPartition,
OffsetAndMetadata>> future;
+ public CompletableFuture<Map<TopicPartition, OffsetAndMetadata>>
future;
+
public OffsetFetchRequestState(final Set<TopicPartition> partitions,
- final GroupState.Generation generation,
Review Comment:
Yes, agree we don't need to send them if we don't have them (member not
using the group management capabilities), but the point is member ID/epoch
should be here to be included if the member has them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
