jlprat commented on code in PR #14540:
URL: https://github.com/apache/kafka/pull/14540#discussion_r1362019221
##########
connect/api/src/main/java/org/apache/kafka/connect/health/ConnectClusterDetails.java:
##########
@@ -27,6 +27,6 @@ public interface ConnectClusterDetails {
* Get the cluster ID of the Kafka cluster backing this Connect cluster.
*
* @return the cluster ID of the Kafka cluster backing this Connect cluster
- **/
+ */
String kafkaClusterId();
}
Review Comment:
Not really relevant, but this file seems to miss a break line at the end of
the file.
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableProducer.java:
##########
@@ -290,7 +290,7 @@ record = new ProducerRecord<>(topic, key, value);
}
}
- /** Returns a string to publish: ether 'valuePrefix'.'val' or 'val' **/
+ /* Returns a string to publish: ether 'valuePrefix'.'val' or 'val' */
Review Comment:
This is javadoc, right? I mean it's really vague but it documents the method
below, so I think it misses a *
```suggestion
/** Returns a string to publish: ether 'valuePrefix'.'val' or 'val' */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
