ijuma commented on code in PR #13787:
URL: https://github.com/apache/kafka/pull/13787#discussion_r1362352735
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -1279,7 +1283,7 @@ class Partition(val topicPartition: TopicPartition,
}
def appendRecordsToLeader(records: MemoryRecords, origin: AppendOrigin,
requiredAcks: Int,
- requestLocal: RequestLocal): LogAppendInfo = {
+ requestLocal: RequestLocal, verificationGuard:
Object = null): LogAppendInfo = {
Review Comment:
@artemlivshits Note that this is Java, so you actually cannot pass an
address (many GC implementations move objects and update their addresses).
> so passing anything is perfectly fine - 2 different objects would have 2
different addresses. null works because we know that it is not equal to any
real object identity.
Actually this is not true, if you pass "foo" this is an interned string
(just as one example).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
