apoorvmittal10 commented on code in PR #14554: URL: https://github.com/apache/kafka/pull/14554#discussion_r1362662718
########## clients/src/main/java/org/apache/kafka/common/requests/GetTelemetrySubscriptionsRequest.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.common.requests; + +import org.apache.kafka.common.message.GetTelemetrySubscriptionsRequestData; +import org.apache.kafka.common.message.GetTelemetrySubscriptionsResponseData; + +import org.apache.kafka.common.protocol.ApiKeys; +import org.apache.kafka.common.protocol.ByteBufferAccessor; +import org.apache.kafka.common.protocol.Errors; + +import java.nio.ByteBuffer; + +public class GetTelemetrySubscriptionsRequest extends AbstractRequest { + + public static class Builder extends AbstractRequest.Builder<GetTelemetrySubscriptionsRequest> { + + private final GetTelemetrySubscriptionsRequestData data; + + public Builder(GetTelemetrySubscriptionsRequestData data) { + this(data, false); + } + + public Builder(GetTelemetrySubscriptionsRequestData data, boolean enableUnstableLastVersion) { Review Comment: The recently added APIs are marked as unstable in `json` which makes sure that ApiVersions response mark them as UNSUPPORTED so clients do not proceed with API call. To use the APIs they need to be enabled and hence this check helps which enables the last supported version. ``` public short highestSupportedVersion(boolean enableUnstableLastVersion) { if (!this.latestVersionUnstable || enableUnstableLastVersion) { return this.highestSupportedVersion; } else { // A negative value means that the API has no enabled versions. return (short) (this.highestSupportedVersion - 1); } } -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
