[jira] [Commented] (KAFKA-6948) Avoid overflow in timestamp comparison

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KAFKA-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507808#comment-16507808
 ] 

ASF GitHub Bot commented on KAFKA-6948:
---------------------------------------

thisthat opened a new pull request #5183: KAFKA-6948 - Change comparison to 
avoid overflow inconsistencies
URL: https://github.com/apache/kafka/pull/5183
 
 
   Change timestamp comparison following what the Java documentation recommends 
to help preventing such errors.
   
   @guozhangwang I create the new PR as requested 😄 
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Avoid overflow in timestamp comparison
> --------------------------------------
>
>                 Key: KAFKA-6948
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6948
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Giovanni Liva
>            Priority: Major
>
> Some comparisons with timestamp values are not safe. This comparisons can 
> trigger errors that were found in some other issues, e.g. KAFKA-4290 or 
> KAFKA-6608.
> The following classes contains some comparison between timestamps that can 
> overflow.
>  * org.apache.kafka.clients.NetworkClientUtils
>  * org.apache.kafka.clients.consumer.internals.ConsumerCoordinator
>  * org.apache.kafka.common.security.kerberos.KerberosLogin
>  * org.apache.kafka.connect.runtime.WorkerSinkTask
>  * org.apache.kafka.connect.tools.MockSinkTask
>  * org.apache.kafka.connect.tools.MockSourceTask
>  * org.apache.kafka.streams.processor.internals.GlobalStreamThread
>  * org.apache.kafka.streams.processor.internals.StateDirectory
>  * org.apache.kafka.streams.processor.internals.StreamThread
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)