CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1364872040
##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -327,6 +328,10 @@ public ControllerResult<BrokerRegistrationReply>
registerBroker(
}
int brokerId = request.brokerId();
BrokerRegistration existing = brokerRegistrations.get(brokerId);
+ if (version < 2 || existing == null || request.previousBrokerEpoch()
!= existing.epoch()) {
Review Comment:
Sounds good. If the version is < 2, we can skip handling it because ELR
can't be enabled. We can adjust it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
