clolov commented on code in PR #14410:
URL: https://github.com/apache/kafka/pull/14410#discussion_r1365167771


##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsProducerTest.java:
##########
@@ -1098,20 +1053,16 @@ public void 
shouldSwallowExceptionOnEosAbortTxInvalidEpoch() {
     }
 
     private void testSwallowExceptionOnEosAbortTx(final RuntimeException 
exception) {
-        mockedProducer.initTransactions();
-        mockedProducer.beginTransaction();
-        expect(mockedProducer.send(record, null)).andReturn(null);
-        mockedProducer.abortTransaction();
-        expectLastCall().andThrow(exception);

Review Comment:
   `mockedProducer.abortTransaction` was expected to throw an exception, this 
doesn't appear to be the case in the new version of this test - is there a 
reason for this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to