divijvaidya commented on code in PR #14586:
URL: https://github.com/apache/kafka/pull/14586#discussion_r1365230997
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java:
##########
@@ -140,17 +139,15 @@ private void verifyDBOptionsMethodCall(final Method
method) throws Exception {
final Object[] parameters =
getDBOptionsParameters(method.getParameterTypes());
try {
- reset(mockedDbOptions);
- replay(mockedDbOptions);
method.invoke(optionsFacadeDbOptions, parameters);
- verify();
- fail("Should have called DBOptions." + method.getName() + "()");
+ final Collection<Invocation> invocations =
mockingDetails(mockedDbOptions).getInvocations();
+ final Set<String> invokedMethodNames =
invocations.stream().map(invocation ->
invocation.getMethod().getName()).collect(Collectors.toSet());
+ assertTrue(invokedMethodNames.contains(method.getName()));
Review Comment:
please add a line which will be printed when this assertion fails..."Should
have called DBOptions." + method.getName() + "()"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
