showuon commented on PR #14573:
URL: https://github.com/apache/kafka/pull/14573#issuecomment-1770924775

   > @showuon @dengziming Thanks for approving the PR. I also have identified 
the root cause of `checkLastFetchedEpochValidation` failure which also needs to 
call `TestUtils.waitUntilLeaderIsKnown` function after creating a topic 
partition. It retrieves the leader epoch for a topic partition too soon after 
creating it which results in value of `-1`. It then uses this incorrect epoch 
for the fetch request and fails. Since it's a same fix, I could perhaps add it 
to this PR as well?
   > 
   > Also even though the other testcases did not fail, maybe just in case they 
should also call `TestUtils.waitUntilLeaderIsKnown` after creating topics.
   
   @tinaselenge , thanks for the investigation! I think we should have another 
PR for this issue since both Ziming and I already reviewed this PR and 
approved. Let's make it merge soon and focus on the other issues separately! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to