apoorvmittal10 commented on PR #14575: URL: https://github.com/apache/kafka/pull/14575#issuecomment-1771452093
@kirktrue @mjsax @AndrewJSchofield Thanks for the feedback. I have tried to address the comments on code or replied. I have structured telemetry package simpler now as like other packages in client/commons i.e. parent `telemetry` and `internals` package. Please let me know if the interfaces exposed by clients for broker (ClienTelemetryReceiver.java, ClientTelemetry.java and ClientTelemetryPayload.java) to implement should be in broker/server specific packages. May be in `server-common/org/apache/kafka/metrics/`? Though server always have `clients/commons` as dependency in server because of all common metrics code as well. Please let knwo what do you folks think. cc: @wcarlson5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
