hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1367663818
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##########
@@ -99,9 +101,17 @@ public class MeteredKeyValueStore<K, V>
RangeQuery.class,
(query, positionBound, config, store) -> runRangeQuery(query,
positionBound, config)
),
+ mkEntry(
+ TimestampedRangeQuery.class,
Review Comment:
Currently, implementing this method in `MeteredTimestampKeyValueStore
`requires copying helper functions from `MeteredKeyValueStore`. However, by
implementing it in `MeteredKeyValueStore`, we can directly utilize these helper
functions and achieve code reuse.
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##########
@@ -99,9 +101,17 @@ public class MeteredKeyValueStore<K, V>
RangeQuery.class,
(query, positionBound, config, store) -> runRangeQuery(query,
positionBound, config)
),
+ mkEntry(
+ TimestampedRangeQuery.class,
+ (query, positionBound, config, store) ->
runTimestampRangeQuery(query, positionBound, config)
+ ),
mkEntry(
KeyQuery.class,
(query, positionBound, config, store) -> runKeyQuery(query,
positionBound, config)
+ ),
+ mkEntry(
+ TimestampedKeyQuery.class,
Review Comment:
https://github.com/apache/kafka/pull/14570#discussion_r1367663818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
