ijuma commented on code in PR #14603:
URL: https://github.com/apache/kafka/pull/14603#discussion_r1369015980
##########
storage/src/main/java/org/apache/kafka/storage/internals/util/CleanShutdownFileHandler.java:
##########
@@ -85,6 +85,7 @@ void write(long brokerEpoch, int version) throws Exception {
}
}
+ @SuppressWarnings("unchecked")
public long read() {
long brokerEpoch = -1L;
Review Comment:
A few comments unrelated to this PR:
1. Should we return `OptionalInt` to make it clear that it can be unset?
2. Should we use a class instead of map to avoid the need to map it back and
forth?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
