apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1370136149
##########
core/src/main/scala/kafka/server/ConfigHelper.scala:
##########
@@ -57,13 +58,15 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
authHelper.authorize(request.context, DESCRIBE_CONFIGS, CLUSTER,
CLUSTER_NAME)
case ConfigResource.Type.TOPIC =>
authHelper.authorize(request.context, DESCRIBE_CONFIGS, TOPIC,
resource.resourceName)
+ case ConfigResource.Type.CLIENT_METRICS =>
+ authHelper.authorize(request.context, DESCRIBE_CONFIGS,
CLIENT_METRICS, resource.resourceName)
Review Comment:
Completely missed it, thanks for that. I have removed declaring new Resource
Type for client_metrics and corresponding checks. Have changed test cases to
authorize on CLUSTER resource for CLIENT_METRICS config source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
