kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1370486899
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##########
@@ -401,12 +524,12 @@ private void maybeThrowInvalidGroupIdException() {
@Override
public Map<MetricName, ? extends Metric> metrics() {
- throw new KafkaException("method not implemented");
+ return Collections.unmodifiableMap(metrics.metrics());
}
@Override
public List<PartitionInfo> partitionsFor(String topic) {
- throw new KafkaException("method not implemented");
+ return partitionsFor(topic, Duration.ofMillis(defaultApiTimeoutMs));
Review Comment:
Good call out. I don't know that the necessary topic plumbing code was
written at that time. Would you mind filing a bug to resolve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
