soarez commented on code in PR #14625:
URL: https://github.com/apache/kafka/pull/14625#discussion_r1371337334
##########
clients/src/test/java/org/apache/kafka/common/record/DefaultRecordBatchTest.java:
##########
@@ -63,15 +61,7 @@
import static org.mockito.Mockito.when;
public class DefaultRecordBatchTest {
- private static final Random RANDOM;
-
- static {
- try {
- RANDOM = SecureRandom.getInstanceStrong();
- } catch (NoSuchAlgorithmException e) {
- throw new RuntimeException(e);
- }
- }
+ private static final Random RANDOM = new Random();
Review Comment:
Perhaps a comment would be useful here to point out why it is preferable to
avoid `SecureRandom.getInstanceStrong()` in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
