divijvaidya commented on code in PR #13321:
URL: https://github.com/apache/kafka/pull/13321#discussion_r1371421492
##########
bin/kafka-run-class.sh:
##########
@@ -229,7 +230,7 @@ if [ -z "$KAFKA_LOG4J_OPTS" ]; then
# Log to console. This is a tool.
LOG4J_DIR="$base_dir/config/tools-log4j.properties"
# If Cygwin is detected, LOG4J_DIR is converted to Windows format.
- (( CYGWIN )) && LOG4J_DIR=$(cygpath --path --mixed "${LOG4J_DIR}")
+ (( WINDOWS_OS_FORMAT )) && LOG4J_DIR=$(cygpath --path --mixed "${LOG4J_DIR}")
KAFKA_LOG4J_OPTS="-Dlog4j.configuration=file:${LOG4J_DIR}"
Review Comment:
We are not using `KAFKA_LOG4J_OPTS` this at the end of the script now, hence
this logic will not be executed.
Could we please revert back to using `KAFKA_LOG4J_OPTS`? Also asking because
folks may already have scripts where they set `KAFKA_LOG4J_OPTS` as an
environment variable. We don't want to break that, hence we need to continue
using `KAFKA_LOG4J_OPTS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
