CalvinConfluent commented on code in PR #14603:
URL: https://github.com/apache/kafka/pull/14603#discussion_r1372064203
##########
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##########
@@ -190,7 +192,7 @@ class BrokerLifecycleManager(
/**
* The broker epoch from the previous run, or -1 if the epoch is not able to
be found.
*/
- @volatile private var previousBrokerEpoch: Long = -1L
+ @volatile private var previousBrokerEpoch: OptionalLong =
OptionalLong.empty()
Review Comment:
Done.
##########
storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/CleanShutdownFileHandler.java:
##########
@@ -45,17 +44,22 @@
public class CleanShutdownFileHandler {
public static final String CLEAN_SHUTDOWN_FILE_NAME =
".kafka_cleanshutdown";
- private final File cleanShutdownFile;
+ // Visible for testing
+ public final File cleanShutdownFile;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
