dajac commented on code in PR #14524:
URL: https://github.com/apache/kafka/pull/14524#discussion_r1373214870
##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -277,6 +279,22 @@ def __init__(self, context, num_nodes, zk,
security_protocol=SecurityConfig.PLAI
self.isolated_controller_quorum = None # will define below if necessary
self.configured_for_zk_migration = False
+ default_use_new_coordinator = False
+
+ # If 'use_new_coordinator' is not explicitly set, determine it based
on context.
+ if use_new_coordinator is None:
+ arg_name = 'use_new_coordinator'
+
+ # Default to the global setting if no arguments are injected.
+ if not context.injected_args:
Review Comment:
Hum... I suppose that I miss some understanding about how `injected_args`
works. My understanding here is that whenever `injected_args` is defined, we
take the value for `use_new_coordinator` from it or default to
`default_use_new_coordinator`. This means that we basically ignore the global
setting in this case.
What is the precedence of those here? value from the constructor, value from
`injected_args` and value from `globals`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
