CalvinConfluent commented on code in PR #14594:
URL: https://github.com/apache/kafka/pull/14594#discussion_r1373424287
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -1096,6 +1102,9 @@ class Partition(val topicPartition: TopicPartition,
* advancing the HW, the follower's log end offset may keep falling behind
the HW (determined by the leader's log end
* offset) and therefore will never be added to ISR.
*
+ * Note, If KIP-966 is enabled, the HW can only advance if the ISR size is
equal or large than the
+ * min ISR(min.insync.replicas).
Review Comment:
When ISR size is equal to min ISR, the HW can advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
