ASF GitHub Bot commented on KAFKA-6562:

ijuma closed pull request #5110: KAFKA-6562: (follow-up) Publish 
"jackson-databind" lib as provided scope dependency in clients maven artifact
URL: https://github.com/apache/kafka/pull/5110

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/build.gradle b/build.gradle
index 911ba09edec..60476eebcf1 100644
--- a/build.gradle
+++ b/build.gradle
@@ -785,11 +785,20 @@ project(':examples') {
 project(':clients') {
   archivesBaseName = "kafka-clients"
+  configurations {
+    jacksonDatabindConfig
+  }
+  // add jacksonDatabindConfig as provided scope config with high priority 
+  conf2ScopeMappings.addMapping(1000, configurations.jacksonDatabindConfig, 
   dependencies {
     compile libs.lz4
     compile libs.snappy
     compile libs.slf4jApi
-    compile libs.jacksonDatabind // for SASL/OAUTHBEARER bearer token parsing
+    compileOnly libs.jacksonDatabind // for SASL/OAUTHBEARER bearer token 
+    jacksonDatabindConfig libs.jacksonDatabind // to publish as provided scope 
     testCompile libs.bcpkix
     testCompile libs.junit
@@ -798,6 +807,7 @@ project(':clients') {
     testCompile libs.powermockEasymock
     testRuntime libs.slf4jlog4j
+    testRuntime libs.jacksonDatabind
   task determineCommitId {
diff --git a/docs/security.html b/docs/security.html
index 877ca579a52..c1682ff8fbf 100644
--- a/docs/security.html
+++ b/docs/security.html
@@ -715,6 +715,8 @@ <h3><a id="security_sasl" href="#security_sasl">7.3 
Authentication using SASL</a
     security.protocol=SASL_SSL (or SASL_PLAINTEXT if non-production)
+             <li>The default implementation of SASL/OAUTHBEARER depends on the 
jackson-databind library.
+                 Since it's an optional dependency, users have to configure it 
as a dependency via their build tool.</li>
         <li><h5><a id="security_sasl_oauthbearer_unsecured_retrieval" 
href="#security_sasl_oauthbearer_unsecured_retrieval">Unsecured Token Creation 
Options for SASL/OAUTHBEARER</a></h5>


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> KIP-255: OAuth Authentication via SASL/OAUTHBEARER
> --------------------------------------------------
>                 Key: KAFKA-6562
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6562
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>            Reporter: Ron Dagostino
>            Assignee: Ron Dagostino
>            Priority: Major
>             Fix For: 2.0.0
> KIP-255: OAuth Authentication via SASL/OAUTHBEARER 
> (https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75968876) 
> proposes adding the ability to authenticate to Kafka with OAuth 2 bearer 
> tokens using the OAUTHBEARER SASL mechanism.  Token retrieval and token 
> validation are both pluggable.

This message was sent by Atlassian JIRA

Reply via email to