mjsax commented on code in PR #14618: URL: https://github.com/apache/kafka/pull/14618#discussion_r1374016565
########## build.gradle: ########## @@ -295,7 +296,12 @@ subprojects { } publications { mavenJava(MavenPublication) { - from components.java + if (!shouldPublishWithShadow) { + from components.java + } else { + apply plugin: 'com.github.johnrengelman.shadow' Review Comment: What is this plugin? Does not look like something official? Not sure if we should use something that is no backed by some official OSS project? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org