mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1374168471
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##########
@@ -617,8 +616,7 @@ public void testRestartConnectorAndTasksBoth() throws
Exception {
when(restartPlan.restartConnectorStateInfo()).thenReturn(connectorStateInfo);
doReturn(Optional.of(restartPlan)).when(herder).buildRestartPlan(restartRequest);
- doNothing().when(herder).onRestart(CONNECTOR_NAME);
- doNothing().when(herder).onRestart(taskId);
+ ArgumentCaptor<TaskStatus> taskStatus =
ArgumentCaptor.forClass(TaskStatus.class);
Review Comment:
I had to add this otherwise
https://github.com/apache/kafka/pull/12728/files#diff-9143727aad47387b8283893ef39610c7f135264077f795f70a6f1d67f7db6e21R151-R153
would fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
