kumarpritam863 commented on PR #14630: URL: https://github.com/apache/kafka/pull/14630#issuecomment-1782659721
@C0urante As I mentioned this is a very small change just a change in the order of calling the same function which updates the partition count. This involves practically no code change and more than that I almost explored all the options to add UNIT or Integration test but it seems very complex adding test cases for this change. But we have tested this in our lower environments with multiple scenarios covering multiple dimensions and we have not encountered any issue. I have already spent a lot of time figuring out ways to add unit test cases. **These are the dew reasons why adding unit test is difficult for this:** 1. Although the change is in workerSinkTask but the root cause of the issue is in ConsumerCoordinator 2. So the current unit test cases for worker sink task mocks the consumer assignment itself. 3. ConsumerCoordinator is not even a dependency for workerSinkTask and it is indirectly accessed via the kafka consumer Client. 4. "onJoinComplete" method is protected and can be called from that module itself. Can we please take this without the test case or with the existing test case. This is a really small change but of utmost important to us as we heavily rely on this metrics. Thank you in advance for your time and consideration. Best regards, Pritam -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
