lihaosky commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1374947218
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##########
@@ -228,7 +231,7 @@ private void emitNonJoinedOuterRecords(
sharedTimeTracker.minTime = timestamp;
// Skip next records if window has not closed
- if (timestamp + joinAfterMs + joinGraceMs >=
sharedTimeTracker.streamTime) {
+ if (sharedTimeTracker.minTime + windowsAfterIntervalMs +
joinGraceMs >= sharedTimeTracker.streamTime) {
Review Comment:
I'm not sure about this part. If the `value` has right value and this is on
right side, why don't we check with `windows.beforeMs` to see if it expires?
Not sure why `windowsAfterIntervalMs` is always set to `windows.afterMs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
