junrao commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1375047867
##########
clients/src/main/java/org/apache/kafka/common/metrics/MetricsReporter.java:
##########
@@ -24,13 +24,14 @@
import org.apache.kafka.common.Reconfigurable;
import org.apache.kafka.common.annotation.InterfaceStability;
import org.apache.kafka.common.config.ConfigException;
+import org.apache.kafka.common.telemetry.ClientTelemetry;
/**
* A plugin interface to allow things to listen as new metrics are created so
they can be reported.
* <p>
* Implement {@link org.apache.kafka.common.ClusterResourceListener} to
receive cluster metadata once it's available. Please see the class
documentation for ClusterResourceListener for more information.
*/
-public interface MetricsReporter extends Reconfigurable, AutoCloseable {
+public interface MetricsReporter extends Reconfigurable, AutoCloseable,
ClientTelemetry {
Review Comment:
I agree with Xavier. Also, the KIP didn't propose to change the
`MetricsReporter` interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
