Lucent-Wong commented on code in PR #14666:
URL: https://github.com/apache/kafka/pull/14666#discussion_r1376291255
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##########
@@ -1335,7 +1339,7 @@ private[group] class GroupCoordinator(
// Failed to persist member.id of the given static member,
revert the update of the static member in the group.
group.updateMember(knownStaticMember, oldProtocols,
oldRebalanceTimeoutMs, oldSessionTimeoutMs, null)
- val oldMember = group.replaceStaticMember(groupInstanceId,
newMemberId, oldMemberId)
+ val oldMember = group.replaceStaticMember(groupInstanceId,
newMemberId, oldMemberId, clientId, clientHost)
Review Comment:
I think you are correct, I didn't realize it should reset these value. I
will update it.
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataTest.scala:
##########
@@ -609,7 +609,7 @@ class GroupMetadataTest {
@Test
def testReplaceGroupInstanceWithNonExistingMember(): Unit = {
val newMemberId = "newMemberId"
- assertThrows(classOf[IllegalArgumentException], () =>
group.replaceStaticMember(groupInstanceId, memberId, newMemberId))
+ assertThrows(classOf[IllegalArgumentException], () =>
group.replaceStaticMember(groupInstanceId, memberId, newMemberId, clientId,
clientHost))
}
@Test
Review Comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
