cmccabe commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1376805476
##########
clients/src/main/java/org/apache/kafka/common/errors/InvalidMetadataException.java:
##########
@@ -19,7 +19,7 @@
/**
* An exception that may indicate the client's metadata is out of date
*/
-public abstract class InvalidMetadataException extends RetriableException {
+public class InvalidMetadataException extends RetriableException {
Review Comment:
Hmm. It seems odd to make this non-abstract. Clearly the intention was to
have a more specific class describe why the metadata was invalid. Why would we
not follow this pattern here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
