Hangleton commented on code in PR #14649:
URL: https://github.com/apache/kafka/pull/14649#discussion_r1377591869
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1754,6 +1754,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
leaderEpochCache.foreach(_.clearAndFlush())
producerStateManager.truncateFullyAndStartAt(newOffset)
logStartOffset = logStartOffsetOpt.getOrElse(newOffset)
+ if (remoteLogEnabled()) maybeIncrementLocalLogStartOffset(newOffset,
LogStartOffsetIncrementReason.SegmentDeletion)
Review Comment:
Actually is this really the right place to update the local log start
offset? The replica fetcher tier state machine already calls
`maybeIncrementLogStartOffset` from
[here](https://github.com/apache/kafka/blob/trunk/core/src/main/java/kafka/server/ReplicaFetcherTierStateMachine.java#L233).
I guess we can add the call to `maybeIncrementLocalLogStartOffset` there too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
