dajac commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1378159050
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##########
@@ -154,6 +158,8 @@ public class PrototypeAsyncConsumer<K, V> implements
Consumer<K, V> {
private AtomicBoolean fencedInstance = new AtomicBoolean(false);
private final Optional<String> groupInstanceId;
+ private ExecutorService callbackExecutor =
Executors.newSingleThreadExecutor();
Review Comment:
This is a bit weird, no? In the current model, I suppose that the callbacks
are executed by the application thread when poll() is called. Should we do the
same here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
