kamalcph commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378454900
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -3117,7 +3117,8 @@ class ReplicaManagerTest {
isShuttingDown: AtomicBoolean = new AtomicBoolean(false),
enableRemoteStorage: Boolean = false,
shouldMockLog: Boolean = false,
- remoteLogManager: Option[RemoteLogManager] = None
+ remoteLogManager: Option[RemoteLogManager] = None,
+ defaultTopicRemoteLogStorageEnable: Boolean = true
Review Comment:
Let's update all the callers instead and supply the flag explicitly:
```
val replicaManager = setupReplicaManagerWithMockedPurgatories(mockTimer,
aliveBrokerIds = Seq(0, 1),
enableRemoteStorage = enableRemoteStorage,
defaultTopicRemoteLogStorageEnable = enableRemoteStorage)
```
The intention is that the default value should resemble the cluster default
which is `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
