apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378824753
##########
core/src/main/scala/kafka/server/ConfigHelper.scala:
##########
@@ -129,6 +130,25 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
(name, value) => new
DescribeConfigsResponseData.DescribeConfigsResourceResult().setName(name)
.setValue(value.toString).setConfigSource(ConfigSource.DYNAMIC_BROKER_LOGGER_CONFIG.id)
.setIsSensitive(false).setReadOnly(false).setSynonyms(List.empty.asJava))
+
+ case ConfigResource.Type.CLIENT_METRICS =>
+ val entityName = resource.resourceName
+ if (resource.resourceName == null ||
resource.resourceName.isEmpty) {
Review Comment:
I have renamed it to `subscriptionName` and used that for checks, thanks for
pointing out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
