mjsax commented on code in PR #14681:
URL: https://github.com/apache/kafka/pull/14681#discussion_r1379448271
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -618,7 +618,7 @@ public ProducerConfig(Map<String, Object> props) {
super(CONFIG, props);
}
- ProducerConfig(Map<?, ?> props, boolean doLog) {
+ protected ProducerConfig(Map<?, ?> props, boolean doLog) {
Review Comment:
We did a similar change w/o a KIP in the past
(https://github.com/apache/kafka/commit/487b95454233e981a65c184c7f3b86adf34058ef)
Actually similar for `ConsumerConfig`
(https://github.com/apache/kafka/commit/283a19481d1ce4a77f5f465e7b96288db22a8ff1)
-- note that while this PR is part of a KIP, the KIP is about something
totally different and does not mention this change at all.
I agree it's borderline, but believe it's ok. -- In the end, I would rather
exclude `protected` stuff from the JavaDocs as I don't think `protected` is
actually public API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
