mjsax commented on code in PR #14596: URL: https://github.com/apache/kafka/pull/14596#discussion_r1379471204
########## streams/src/main/java/org/apache/kafka/streams/query/VersionedKeyQuery.java: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.query; + +import java.time.Instant; +import java.util.Objects; +import java.util.Optional; +import org.apache.kafka.common.annotation.InterfaceStability.Evolving; +import org.apache.kafka.streams.state.VersionedRecord; + +/** + * Interactive query for retrieving a single record from a versioned state store based on its key and timestamp. + * + * @param <K> The type of the key. + * @param <V> The type of the value. + */ +@Evolving +public final class VersionedKeyQuery<K, V> implements Query<VersionedRecord<V>> { + + private final K key; + private final Optional<Instant> asOfTimestamp; + + private VersionedKeyQuery(final K key, final Optional<Instant> asOfTimestamp) { + this.key = Objects.requireNonNull(key); Review Comment: This null check should go into `withKey(...)` (to get flatter stack traces). We should also add an error message: `Objects.requireNonNull(key, "key cannot be null");` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
