mjsax commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1379585726
##########
build.gradle:
##########
@@ -295,7 +296,12 @@ subprojects {
}
publications {
mavenJava(MavenPublication) {
- from components.java
+ if (!shouldPublishWithShadow) {
+ from components.java
+ } else {
+ apply plugin: 'com.github.johnrengelman.shadow'
Review Comment:
Thanks. Yes, I understood already what the plugin does.
> This dependency is not introduced in this PR rather being already used in
Kafka for a while:
This was my concern, but if it's already established my concerns are void.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
